help with a while loop

**s3nzo** · 07.09.11, 02:02

Try this

PHP Code:


if($action=="males") 
{ 
  addonline(getuid_sid($sid),"Male Gallery",""); 

echo "<body>"; 
   
  echo "<p align=\"center\"><small>"; 
  echo "<i><b><u>Male Users From $sitename</u></b></i>"; 
  echo "<br/><br/>"; 
  echo "</small></p>"; 
   //////ALL LISTS SCRIPT << 
   $uid1 = getuid_sid($sid);  
$mid = $_GET["mid"]; 
    if($page=="" || $page<=0)$page=1; 
    $noi = mysql_fetch_array(mysql_query("SELECT COUNT(*) FROM usergallery WHERE sex='M'")); 
$num_items = $noi[0]; //changable 
    $items_per_page= 5; 
    $num_pages = ceil($num_items/$items_per_page); 
    if(($page>$num_pages)&&$page!=1)$page= $num_pages; 
    $limit_start = ($page-1)*$items_per_page; 
$sql = "SELECT uid, id, imageurl FROM usergallery WHERE sex='M' ORDER BY id DESC LIMIT $limit_start, $items_per_page"; 
///////////////////// part of the added code also.  
$result = mysql_query($sql) or die("Error: " . mysql_error());  
//// 
echo "<p>"; 
    $items = mysql_query($sql); 
    echo mysql_error(); 
    if(mysql_num_rows($items)>0) 
    { 
    while ($item = mysql_fetch_array($items)) 
    { 
        $sql = "SELECT rating FROM usergallery_rating WHERE imageid='".$item[1]."'";         
        $imginfo = mysql_query($sql); 
        echo mysql_error(); 
        if(mysql_num_rows($imginfo)>0) 
        { 
           while ($imginfos = mysql_fetch_array($imginfo)){  
              $ratingtotal = $ratingtotal + $imginfos[0];} 
        } 
        if($totalcomments<1)
            {
                $totalcomments=0;
            }          
            $norm = mysql_fetch_array(mysql_query("SELECT COUNT(*) FROM usergallery_rating WHERE imageid='".$item[1]."'")); 
        if ($norm[0]>0)
            { 
                $rating = ceil($ratingtotal/$norm[0]); 
            }
        else
            {
                $rating=0;
            } 
        $rated = mysql_fetch_array(mysql_query("SELECT COUNT(*) FROM usergallery_rating WHERE byuid='".$uid1."' and imageid ='".$item[1]."'")); 
        $totalcomments = mysql_fetch_array(mysql_query("SELECT COUNT(*) FROM usergallery_rating WHERE imageid ='".$item[1]."' and commentsyn ='Y'")); 
        $userinfo = mysql_fetch_array(mysql_query("SELECT name FROM users WHERE id='".$item[0]."'")); 
        echo "<a href=\"index.php?action=viewuser&amp;who=$item[0]&amp;sid=$sid\"><b><i><u>$userinfo[0]</u></i></b></a><small>"; 
        if(canratephoto($uid1, $item[0]) and ($rated[0]==0)) 
            { 
                echo "<br/><a href=\"usergallery.php?action=rate&amp;sid=$sid&amp;whoimage=$item[1]\">Rate This Photo</a>"; 
            } 
        if(ishost(getuid_sid($sid))||((isowner(getuid_sid($sid))||((isheadadmin(getuid_sid($sid))))))) 
            { 
                echo " / <a href=\"usergallery.php?action=del&amp;sid=$sid&amp;whoimage=$item[1]\">Del</a>"; 
            } 
        if($uid1==$item[0]) 
            { 
                echo " / <a href=\"usergallery.php?action=del&amp;sid=$sid&amp;whoimage=$item[1]\">Del</a>"; 
            } 
         if($uid1==$item[0]) 
            { 
                echo "<br/><a href=\"genproc.php?action=upavg&amp;sid=$sid&amp;avsrc=$item[2]\">Use As profile pic</a>"; 
            } 
        
  
        echo "<small>Rating: $rating/10 (<a href=\"usergallery.php?action=votes&amp;sid=$sid&amp;whoimage=$item[1]\">$norm[0]</a> Votes)<br/><a href=\"usergallery.php?action=comments&amp;sid=$sid&amp;whoimage=$item[1]\">Comments</a>($totalcomments[0])"; 
        echo "</small><br/><a href=\"$item[2]\" alt=\"$userinfo[0]\"/>Download<br/>"; 
////////////////////////my problem part 
while($row = mysql_fetch_array($result)){ 
echo "</small><br/><img src=\"$item[2]\" alt=\"$userinfo[0]\"/><br/>";
echo "<br/><a href=\"getpics.php?file=$row[id]&amp;sid=$sid\">Download test</a>"; 
<br/>"; 
} 
//////////////////////// 
        echo "</small><br/><br/>"; 
        $ratingtotal = 0; 
         
    } 
    } 
     
    echo "</p>"; 
    echo "<p align="center\">"; 
    if($page>1) 
    { 
      $ppage = $page-1; 
      echo "<a href=\"usergallery.php?action=males&amp;sid=$sid&amp;page=$ppage\">«Prev</a> "; 
    } 
    if($page<$num_pages) 
    { 
      $npage = $page+1; 
      echo "<a href=\"usergallery.php?action=males&amp;sid=$sid&amp;page=$npage\">Next»</a>"; 
    } 
    echo "<br/>$page/$num_pages<br/>"; 
    if($num_pages>2) 
    { 
      $rets = "<form action=\"usergallery.php\" method=\"get\"><p align=\"center\">"; 
     
    $rets .= "<input name=\"page\" style=\"-wap-input-format: '*N'\" size=\"3\"/>"; 
    $rets .= "<input type=\"hidden\" name=\"sid\" value=\"$sid\"/>"; 
    $rets .= "<input type=\"hidden\" name=\"action\" value=\"$action\"/>"; 
    $rets .= "<input type=\"hidden\" name=\"view\" value=\"$view\"/>"; 
    $rets .= "<input type=\"Submit\" value=\"Go To Page\" Name=\"Submit\"/></form>"; 

        echo $rets; 
    } 
    echo "</p>";  
  ////// UNTILL HERE >>  
    echo "<p align=\"center\">"; 
   echo "<br/><br/><a href=\"usergallery.php?action=main&amp;sid=$sid\">«Back to Gallery</a><br/>"; 
    echo "<a href=\"index.php?action=main&amp;sid=$sid\"><img src=\"images/home.gif\" alt=\"*\"/>"; 
echo "Home</a>"; 
  echo "</p>"; 
 echo"</body>"; 
exit();

**nclemale36** · 07.09.11, 10:23

that just gives me 6 of the same picture .

**s3nzo** · 07.09.11, 10:52

If you don't mind me asking why did you use the nested while loop? maybe if you remove the nested loop it will work

**nclemale36** · 07.09.11, 11:28

whats a nested loop . i just copied parts to try and make it work .but i have been looking at the query and realised i didnt need as much info in the result as i was collecting.

Code:

$sql = "SELECT id FROM usergallery WHERE sex='M' ORDER BY id DESC LIMIT $limit_start, $items_per_page";
$result = mysql_query($sql) or die("Error: " . mysql_error()); 
while($row = mysql_fetch_array($result)){
$id = $row["id"];
echo "<a href=\"getpics.php?file=$row[id]&amp;sid=$sid\">Download test</a>";
}

trimmed it down and took the imageurl and uid out .and now am getting the full 5 pics all in correct place. but also the full 5 download links on each of the pictures in a line.

Added after 29 minutes:

i have sorted it. without using any loops .