Thread: What wrong this code?

there is quite a lot wrong with it ..... but question is are you trying to print or echo the link in php?

Originally Posted by utpal [Only registered and activated users can see links. Click Here To Register...]

Any one tell me what wrong this code?

Code:

<a href='".$file." ;="" onclick="top()"'>-Download Now-</a>

It show
Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ';' in /home/mysite/public_html/a/file.php on line 55
Please any one help me

PHP Code:

echo"<a href='".$file." onclick=".top()."'>-Download Now-</a>"; 


onclick="top()" missed dots :p

onclick=".top()."

Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in C:\Program Files (x86)\VertrigoServ\www\test.php on line 4

Originally Posted by just_m3. [Only registered and activated users can see links. Click Here To Register...]

PHP Code:

echo"<a href='".$file." onclick=".top()."'>-Download Now-</a>"; 


still wrong :/

PHP Code:

echo "<a href='".$file."' onclick='top()'>-Download Now-</a>"; 


javascript needs to be inside the string

Originally Posted by something else [Only registered and activated users can see links. Click Here To Register...]

still wrong :/

PHP Code:

echo "<a href='".$file."' onclick='top()'>-Download Now-</a>"; 


javascript needs to be inside the string

ooops :D m'a bad .. i didn't knew that top() is from js function ..

Originally Posted by just_m3. [Only registered and activated users can see links. Click Here To Register...]

ooops :D m'a bad .. i didn't knew that top() is from js function ..

if it was a php function your post would be still wrong as your missing two '
eg:

PHP Code:

echo "<a href='".$file."' onclick='".top()."'>-Download Now-</a>"; 


Originally Posted by something else [Only registered and activated users can see links. Click Here To Register...]

if it was a php function your post would be still wrong as your missing two '
eg:

PHP Code:

echo "<a href='".$file."' onclick='".top()."'>-Download Now-</a>"; 


OMFG i'm so dizzy today (nasty day at work) ... missed that too ... :p

PHP Code:

echo "<a href='".$file."' onclick='".top()."'>-Download Now-</a>"; 


how's it now ?

but that's why you are here .. to fix things !


and let me tell ya ' one more thing about another day like this .. i wass so dizzy that i didn't knew why listing all data from database ain't work. (missed while function !)

but that's another part of me .. haha .. tnx for that one :p

Originally Posted by just_m3. [Only registered and activated users can see links. Click Here To Register...]

OMFG i'm so dizzy today (nasty day at work) ... missed that too ... :p

PHP Code:

echo "<a href='".$file."' onclick='".top()."'>-Download Now-</a>"; 


how's it now ?

but that's why you are here .. to fix things !


and let me tell ya ' one more thing about another day like this .. i wass so dizzy that i didn't knew why listing all data from database ain't work. (missed while function !)

but that's another part of me .. haha .. tnx for that one :p

My java scripts is

Code:

<script type="text/javascript">
function top()
{
window.open("http://google.com","funlive","width=1%, height=1%, toolbar=no,location=no, directories=no, status=no, menubar=no, scrollbars=no, resizable=no, copyhistory=yes");
}

</script>

and

PHP Code:

echo "<a href='".$file."' onclick='".top()."'>-Download Now-</a>"; 


this code also Fatal error..
Please help me.

use my second post